fix(rulesets): drop ksail benchmark-data deletion ruleset#73
Merged
Merged
Conversation
The ksail "Restrict deletions" ruleset (scoped to refs/heads/benchmark-data) was adopted here Observe-only. ksail is removing its benchmark subsystem (devantler-tech/ksail#5503), and the benchmark-data branch plus its GitHub ruleset (id 14699634) have now been deleted. Because the managed resource is Observe-only it cannot recreate the external ruleset, so it reconciles in error ("external resource does not exist"). Remove the declarative source so Flux prunes the orphaned RepositoryRuleset: - delete deploy/repository-rulesets/restrict-deletions-on-ksail.yaml - drop it from the repository-rulesets kustomization - update both rulesets READMEs The org-wide "Restrict deletions" ruleset is unaffected (it never targeted benchmark-data). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![botantler-1[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
deploy/repository-rulesets/restrict-deletions-on-ksail.yamldeclares ksail's "Restrict deletions" ruleset (scoped torefs/heads/benchmark-data) as an Observe-only Crossplane managed resource.ksail is removing its entire benchmark subsystem (devantler-tech/ksail#5503). As part of that, the
benchmark-databranch and its GitHub ruleset (id14699634) have been deleted. Because the managed resource ismanagementPolicies: ["Observe"], Crossplane cannot recreate the external ruleset — it just keeps observing a missing resource and reconciling in error:What changed
Remove the declarative source so Flux prunes the orphaned managed resource and the warnings stop:
deploy/repository-rulesets/restrict-deletions-on-ksail.yamldeploy/repository-rulesets/kustomization.yamldeploy/repository-rulesets/README.mdanddeploy/organization-rulesets/README.mdNot affected
OrganizationRuleset— it never targetedbenchmark-data(verified:gh api repos/devantler-tech/ksail/rules/branches/benchmark-datareturned only ruleset14699634).require-merge-queue-on-platform.yaml— the only remaining repository ruleset.Validation
kustomize build deploy/repository-rulesetsandkustomize build deployboth succeed; no dangling references to the removed manifest remain.🤖 Generated with Claude Code